update suggestion messaging for --no-kubernetes #12933

klaases · 2021-11-11T22:55:42Z

Replaces #12925

Before:

minikube start --no-kubernetes

😄  minikube v1.24.0 on Darwin 11.6.1
✨  Automatically selected the docker driver
👍  Starting minikube without Kubernetes minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=1985MB) ...
🏄  Done! minikube is ready without Kubernetes!
╭───────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                       │
│                       💡  Things to try without Kubernetes ...                        │
│                                                                                       │
│    - "minikube ssh" to SSH into minikube's node.                                      │
│    - "minikube docker-env" to point your docker-cli to the docker inside minikube.    │
│    - "minikube image" to build images without docker.                                 │
│                                                                                       │
╰───────────────────────────────────────────────────────────────────────────────────────╯

After:

minikube start --no-kubernetes --container-runtime=docker

😄  minikube v1.24.0 on Darwin 11.6.1
✨  Automatically selected the docker driver
👍  Starting minikube without Kubernetes minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=1985MB) ...
🏄  Done! minikube is ready without Kubernetes!
╭───────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                       │
│                       💡  Things to try without Kubernetes ...                        │
│                                                                                       │
│    - "minikube ssh" to SSH into minikube's node.                                      │
│    - "minikube docker-env" to point your docker-cli to the docker inside minikube.    │
│    - "minikube image" to build images without docker.                                 │
│                                                                                       │
╰───────────────────────────────────────────────────────────────────────────────────────╯

minikube delete --all

🔥  Deleting "minikube" in docker ...
🔥  Removing /Users/x/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.
🔥  Successfully deleted all profiles

minikube start --no-kubernetes --container-runtime=containerd

😄  minikube v1.24.0 on Darwin 11.6.1
✨  Using the docker driver based on existing profile
👍  Starting minikube without Kubernetes minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🏄  Done! minikube is ready without Kubernetes!
╭──────────────────────────────────────────────────────────╮
│                                                          │
│         💡  Things to try without Kubernetes ...         │
│                                                          │
│    - "minikube ssh" to SSH into minikube's node.         │
│    - "minikube image" to build images without docker.    │
│                                                          │
╰──────────────────────────────────────────────────────────╯

minikube delete --all

🔥  Deleting "minikube" in docker ...
🔥  Removing /Users/x/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.
🔥  Successfully deleted all profiles

minikube start --no-kubernetes --container-runtime=crio

😄  minikube v1.24.0 on Darwin 11.6.1
✨  Automatically selected the docker driver
👍  Starting minikube without Kubernetes minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=1985MB) ...
🏄  Done! minikube is ready without Kubernetes!
╭───────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                       │
│                       💡  Things to try without Kubernetes ...                        │
│                                                                                       │
│    - "minikube ssh" to SSH into minikube's node.                                      │
│    - "minikube podman-env" to point your podman-cli to the podman inside minikube.    │
│    - "minikube image" to build images without docker.                                 │
│                                                                                       │
╰───────────────────────────────────────────────────────────────────────────────────────╯

k8s-ci-robot · 2021-11-11T22:55:50Z

Hi @klaases. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-11-11T22:56:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: klaases
To complete the pull request process, please assign medyagh after the PR has been reviewed.
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2021-11-11T22:57:04Z

Can one of the admins verify this patch?

medyagh

how about a better PR title
for example:
"update suggestion messaging for --no-kubernetes"

medyagh · 2021-11-11T23:04:16Z

pkg/minikube/constants/constants.go

@@ -56,6 +56,8 @@ const (
 	SSHPort = 22
 	// RegistryAddonPort os the default registry addon port
 	RegistryAddonPort = 5000
+	// Containerd is the default name and spelling for the containerd container runtime
+	Containerd = "containerd"


should this be in cruntime package?

or a follow up PR to move them later

medyagh · 2021-11-11T23:21:43Z

/ok-to-test

minikube-pr-bot · 2021-11-12T02:48:40Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestOffline (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/Stop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/false/NetCatPod (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh)	1.27 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/Pause (gopogh)	3.16 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	12.50 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	13.16 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh)	19.19 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh)	19.19 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	19.19 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	19.19 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	20.51 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	20.79 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	21.05 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	21.50 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	23.08 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	24.30 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	29.91 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	35.51 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	46.85 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	46.85 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	68.38 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	70.10 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	71.05 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	72.65 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartNoArgs (gopogh)	81.82 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	83.33 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh · 2021-11-12T20:20:55Z

Looks good to me

klaases added 2 commits November 11, 2021 14:49

update message by runtime

4238bc1

Add "minikube image" message.

532b383

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2021

k8s-ci-robot requested review from prasadkatti and spowelljr November 11, 2021 22:56

medyagh reviewed Nov 11, 2021

View reviewed changes

klaases changed the title ~~Update showKubectlInfo for docker message.~~ update suggestion messaging for --no-kubernetes Nov 11, 2021

medyagh reviewed Nov 11, 2021

View reviewed changes

klaases changed the title ~~update suggestion messaging for --no-kubernetes~~ Update showKubectlInfo for docker message. Nov 11, 2021

klaases changed the title ~~Update showKubectlInfo for docker message.~~ update suggestion messaging for --no-kubernetes Nov 11, 2021

klaases mentioned this pull request Nov 11, 2021

(x) update suggestion messaging for --no-kubernetes #12925

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2021

medyagh merged commit 8bd28a6 into kubernetes:master Nov 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update suggestion messaging for --no-kubernetes #12933

update suggestion messaging for --no-kubernetes #12933

Uh oh!

klaases commented Nov 11, 2021

Uh oh!

k8s-ci-robot commented Nov 11, 2021

Uh oh!

k8s-ci-robot commented Nov 11, 2021

Uh oh!

minikube-bot commented Nov 11, 2021

Uh oh!

medyagh left a comment

Uh oh!

medyagh Nov 11, 2021

Uh oh!

medyagh Nov 11, 2021

Uh oh!

medyagh commented Nov 11, 2021

Uh oh!

minikube-pr-bot commented Nov 12, 2021

Uh oh!

medyagh commented Nov 12, 2021

Uh oh!

Uh oh!

update suggestion messaging for --no-kubernetes #12933

update suggestion messaging for --no-kubernetes #12933

Uh oh!

Conversation

klaases commented Nov 11, 2021

Uh oh!

k8s-ci-robot commented Nov 11, 2021

Uh oh!

k8s-ci-robot commented Nov 11, 2021

Uh oh!

minikube-bot commented Nov 11, 2021

Uh oh!

medyagh left a comment

Choose a reason for hiding this comment

Uh oh!

medyagh Nov 11, 2021

Choose a reason for hiding this comment

Uh oh!

medyagh Nov 11, 2021

Choose a reason for hiding this comment

Uh oh!

medyagh commented Nov 11, 2021

Uh oh!

minikube-pr-bot commented Nov 12, 2021

Uh oh!

medyagh commented Nov 12, 2021

Uh oh!

Uh oh!