Skip to content

Fix starting on Windows with VMware driver on non C: drive #12819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fix starting on Windows with VMware driver on non C: drive #12819

merged 1 commit into from
Oct 29, 2021

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Oct 29, 2021 •
edited
Loading

Fixes #12271

Problem:
When starting minikube on Windows machine with the VMware driver with MINIKUBE_HOME set to a non C: drive, it fails to download the ISO from the host to the VM. This is because the drive is not prepended to the ISO path on the host so it defaults to the C: drive.

Solution:
This issue of not prepending the ISO path with the drive was solved on machine-drivers/machine with machine-drivers/machine#22, however machine-drivers/docker-machine-driver-vmware was instead using docker/machine so I created a PR (machine-drivers/docker-machine-driver-vmware#47) to use machine-drivers/machine instead. This PR updates the version of machine-drivers/docker-machine-driver-vmware to include the changes mentioned above.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 29, 2021
@spowelljr spowelljr merged commit 30ad435 into kubernetes:master Oct 29, 2021
@spowelljr spowelljr deleted the fixVMwareWindows branch October 29, 2021 22:09
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12819) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 47.6s               |
| enable ingress | 32.1s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.8s 32.3s 33.7s 32.3s 31.2s
Times for minikube (PR 12819) ingress: 31.4s 30.3s 31.8s 31.3s 32.3s

Times for minikube start: 50.1s 47.3s 47.2s 46.5s 46.7s
Times for minikube (PR 12819) start: 47.2s 47.8s 48.5s 48.2s 46.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12819) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.3s               |
| enable ingress | 33.8s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.6s 21.7s 21.2s 21.7s 22.2s
Times for minikube (PR 12819) start: 20.9s 21.6s 21.4s 20.9s 21.9s

Times for minikube ingress: 31.4s 37.4s 27.9s 36.9s 35.4s
Times for minikube (PR 12819) ingress: 27.4s 28.4s 35.4s 27.9s 37.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12819) |
+----------------+----------+---------------------+
| minikube start | 38.9s    | 41.0s               |
| enable ingress | 32.5s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube start: 26.8s 43.8s 47.1s 36.4s 40.5s
Times for minikube (PR 12819) start: 36.1s 36.7s 43.1s 44.6s 44.3s

Times for minikube ingress: 33.4s 32.4s 32.4s 30.4s 33.9s
Times for minikube (PR 12819) ingress: 26.4s 26.4s 36.9s 33.4s 33.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 13.07 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh Awaiting requested review from medyagh

1 more reviewer

@sharifelgamal sharifelgamal sharifelgamal approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation Minikube to Drive D: fails (Drive C: is ok)
4 participants
@spowelljr @k8s-ci-robot @minikube-pr-bot @sharifelgamal