-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/improvementCategorizes issue or PR as related to improving upon a current feature.Categorizes issue or PR as related to improving upon a current feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Description
What Happened?
we have a func called tryRegistry
func tryRegistry(r command.Runner, driverName, imageRepository, ip string) {
...
...
if rr, err := r.RunCmd(exec.Command("curl", opts...)); err != nil {
out.WarningT("This {{.type}} is having trouble accessing https://{{.repository}}", out.V{"repository": imageRepository, "type": driver.MachineType(driverName)})
...
}
this func will warn the user if it fails to connect to the registry INSIDE minikbue, however we should do the same check outside minikube (only if the inside one fails)
that way when we debug something like this issue,
we will see in the logs that if the user's computer had any network issue or could it be related to a network module config change in minikbue ISO
Attach the log file
n/a
Operating System
None
Driver
None
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/improvementCategorizes issue or PR as related to improving upon a current feature.Categorizes issue or PR as related to improving upon a current feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.