Skip to content

restore e2fsprogs in hyperkube image #52798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2017
Merged

restore e2fsprogs in hyperkube image #52798

merged 2 commits into from
Sep 20, 2017

Conversation

rphillips
Copy link
Member

@rphillips rphillips commented Sep 20, 2017 •
edited by ericchiang
Loading

What this PR does / why we need it:
Kubernetes defaults to the ext4 filesystem if no filesystem is specified. Unformatted filesystems are not able to be mounted without these tools.

The default ext{2,3,4} tools and mkfs.* utilities should be included in the hyperkube image.

Which issue this PR fixes: Fixes #52789 #50802

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @rphillips. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 20, 2017
@rphillips
Copy link
Member Author

/sig node
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Sep 20, 2017
@xiangpengzhao
Copy link
Contributor

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2017
@rphillips
Copy link
Member Author

/retest

@zmerlynn
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2017
@lucab lucab mentioned this pull request Sep 20, 2017
Merged
@jamiehannaford
Copy link
Contributor

Awesome, thanks for submitting this so quickly!

@ixdy
Copy link
Contributor

ixdy commented Sep 20, 2017 •
edited
Loading

/lgtm cancel

This PR as-written isn't sufficient to fix the issue. You'll need to bump the tag in build/debian-hyperkube-base/Makefile and cluster/images/hyperkube/Makefile, along with building/pushing a new base image (I can help with that).

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2017
@rphillips
Copy link
Member Author

@ixdy pushed the tag tweaks

@ixdy ixdy added this to the v1.8 milestone Sep 20, 2017
@ixdy
Copy link
Contributor

ixdy commented Sep 20, 2017

Building these now.

FYI @tallclair

@dims
Copy link
Member

dims commented Sep 20, 2017

/retest

@dims
Copy link
Member

dims commented Sep 20, 2017

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2017
@ixdy
Copy link
Contributor

ixdy commented Sep 20, 2017

images pushed.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, rphillips, zmerlynn

Associated issue: 52789

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jamiehannaford jamiehannaford mentioned this pull request Sep 20, 2017
Closed
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52477, 52790, 52798). If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit d83c8bc into kubernetes:master Sep 20, 2017
@jamiehannaford
Copy link
Contributor

@ixdy @dims Will this be included in a new beta release (e.g. hyperkube:v1.8.0-beta.2), or will we have to wait until the stable release on the 27th?

@dims
Copy link
Member

dims commented Sep 21, 2017

@jamiehannaford will bring it up in the burndown meeting as i don't know the answer

@rphillips
Copy link
Member Author

This PR was cherry picked into the 1.8 release branch. I suspect it will be built into the next beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@zmerlynn zmerlynn

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

v1.8 hyperkube images don't allow the kubelet to mount
9 participants
@rphillips @k8s-ci-robot @xiangpengzhao @zmerlynn @jamiehannaford @ixdy @dims @k8s-github-robot @jbeda