Skip to content

Conversation

harryfei
Copy link

@harryfei harryfei commented Sep 14, 2016

When we run kubernete in a docker container, the glusterfs volume doesn't work.
This PR add glusterfs-client package in hyperkube image to fix the bug.


This change is Reviewable

To make glusterfs volume workable when running kubernetes in a docker container.
@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "ok to test" on its own line.

Regular contributors should join the org to skip this step.

While we transition away from the Jenkins GitHub PR Builder plugin, "ok to test" commenters will need to be on the admin list defined in this file.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@harryfei
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 14, 2016
@eparis
Copy link
Contributor

eparis commented Sep 14, 2016

@rootfs @luxas
@kubernetes/sig-storage do we need to add other client tools?

@rootfs
Copy link
Contributor

rootfs commented Sep 14, 2016

rbd will be another one.

does hyperkube mount a volume in host's namespace or it doesn't care?

@luxas
Copy link
Member

luxas commented Sep 14, 2016

ok to test

@eparis
Copy link
Contributor

eparis commented Sep 14, 2016

Does this package exist on all of the arches we support? (@luxas)

@eparis
Copy link
Contributor

eparis commented Sep 14, 2016

'hyperkube' is basically all of the binaries jammed together into one big ball, kinda like the openshift binary. Think of this as 'containerized kubelet' and what needs to be inside the container with the kubelet.

@luxas
Copy link
Member

luxas commented Sep 14, 2016

@eparis Yes, debian is the same everywhere.

Right now it's possible to use the --containerized hack in order to run in a container and use mount tools on host, but --containerized is a hack and half-deprecated, so we're not using it anymore.

The current solution (mounting /var/lib/kubelet as a shared volume) works very well, but then all volume deps have to be inside the container. So +1 for this, but only short term.

I'd really like to proceed on the containerized flexvolume proposal that we have, that would be an awesome feature and would help in other cases as well.

@eparis eparis added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 14, 2016
@harryfei
Copy link
Author

@eparis The e2e test is failed. But I have no idea about it. Can you give some suggestion?

@luxas
Copy link
Member

luxas commented Sep 15, 2016

@k8s-bot test this please, issue #IGNORE

@luxas
Copy link
Member

luxas commented Sep 15, 2016

@fangyuanziti That is completely unrelated to this patch.
We call it a flake where a test should pass but doesn't.

@k8s-bot
Copy link

k8s-bot commented Sep 15, 2016

GCE e2e build/test passed for commit fe411b0.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d125649 into kubernetes:master Sep 15, 2016
@aaronlevy aaronlevy mentioned this pull request Oct 11, 2016
@pcm32
Copy link

pcm32 commented Oct 12, 2016

@eparis is this available in the latest release (1.4.1) or earlier? Thanks!

@rootfs
Copy link
Contributor

rootfs commented Mar 14, 2017

Per info below, this looks causing trouble on glusterfs servers with higher rev
#43069

@harryfei harryfei deleted the add_glusterfs_client branch October 29, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants