Skip to content

kube-apiserver: removed the deprecated the --cloud-provider and --cloud-config CLI parameters. #130162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

kube-apiserver: removed the deprecated the --cloud-provider and --cloud-config CLI parameters. #130162

merged 3 commits into from
Feb 18, 2025

Conversation

carlory
Copy link
Member

@carlory carlory commented Feb 14, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

A follow-up of #120903

Which issue(s) this PR fixes:

Related to kubernetes/enhancements#2395

Special notes for your reviewer:

Does this PR introduce a user-facing change?

1. kube-apiserver: removed the deprecated the `--cloud-provider` and `--cloud-config` CLI parameters.
2. removed generally available feature-gate `DisableCloudProviders` and `DisableKubeletCloudCredentialProviders`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2395

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 14, 2025
@carlory
Copy link
Member Author

carlory commented Feb 14, 2025

/cc @dims @elmiko @andrewsykim

@dims
Copy link
Member

dims commented Feb 14, 2025

thanks @carlory ! will leave this for sig-cloud-provider approvers. once there is an lgtm, please ping me for approval.

@elmiko
Copy link
Contributor

elmiko commented Feb 14, 2025

i'm going to need some time to review this, as i recall there were some tricky corner cases we had worked around in the past. thank you @carlory !

@carlory
kube-apiserver: removed the deprecated the --cloud-provider and `--…
29e5d42 
…cloud-config` CLI parameters.

Signed-off-by: carlory <baofa.fan@daocloud.io>
@carlory
remove Removed generally available feature-gate DisableCloudProviders…
2382c01 
… and DisableKubeletCloudCredentialProviders

Signed-off-by: carlory <baofa.fan@daocloud.io>
@carlory carlory force-pushed the remove-cloud-provider-and-cloud-config-in-apiserver-CLI branch from 3678064 to 2382c01 Compare February 17, 2025 02:00
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Feb 17, 2025
@carlory
fix ci
c48499d 
Signed-off-by: carlory <baofa.fan@daocloud.io>
@carlory carlory force-pushed the remove-cloud-provider-and-cloud-config-in-apiserver-CLI branch from c133c93 to c48499d Compare February 17, 2025 03:49
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 17, 2025
elmiko
elmiko reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @carlory !

/lgtm

@Jefftree Jefftree mentioned this pull request Feb 19, 2025
Merged
@aojea
Copy link
Member

aojea commented Feb 20, 2025

this is breaking a lot of CIs :)

kubernetes-sigs/cloud-provider-kind#216

@elmiko
Copy link
Contributor

elmiko commented Feb 20, 2025

seems like it, which is odd because everything was green here. but i gather it's the transitive tests that are having an issue.

@stlaz stlaz mentioned this pull request Feb 20, 2025
Merged
@aojea
Copy link
Member

aojea commented Feb 20, 2025

seems like it, which is odd because everything was green here. but i gather it's the transitive tests that are having an issue.

the change looks correct to me, seems most of the installers and/or installations just plumbed all the feature gates and flags to all teh components, but AFAIK kube-apiserver never used the flag, just the feature gates

@dims
Copy link
Member

dims commented Feb 20, 2025

:)

image

This was referenced Feb 20, 2025
Closed
Closed
@mainred
Copy link

mainred commented Feb 21, 2025

Deprecating control plane args can always lead to CI failures, can we involve sig testing to make announcement through like the official mailing list https://groups.google.com/g/kubernetes-sig-testing.
This will save a lot of dev effort to debug the cluster failure. Thanks.

@stlaz stlaz mentioned this pull request Feb 24, 2025
Merged
@chrischdi chrischdi mentioned this pull request Feb 25, 2025
Merged
@Karthik-K-N Karthik-K-N mentioned this pull request Feb 27, 2025
Open
@arshadd-b arshadd-b mentioned this pull request Mar 6, 2025
Closed
@akhilerm
Copy link
Member

akhilerm commented Apr 3, 2025

Shouldnt this flag be removed from the kubelet options also along with kube-apiserver? https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/options/options.go#L300

@carlory
Copy link
Member Author

carlory commented Apr 3, 2025

#130161 will remove it but it can not be merged due to code freeze. I split it into two prs according to different sig.

@elmiko
Copy link
Contributor

elmiko commented Apr 16, 2025

i believe we still need the option on kubelet so that users can specify --cloud-provider=external, unless i've missed something about how to configure an external ccm.

@carlory
Copy link
Member Author

carlory commented Apr 16, 2025

@elmiko you are right. kubelet need this flag. we should not remove it. I misread the link.

@carlory
Copy link
Member Author

carlory commented Apr 16, 2025

we only remove the deprecated flag --cloud-config from the kubelet command line.

@elmiko
Copy link
Contributor

elmiko commented Apr 16, 2025

yeah, i agree we can remove --cloud-config.

@FabianSchurig FabianSchurig mentioned this pull request Apr 24, 2025
Open
yankcrime added a commit to nscaledev/uni-helm-cluster-api that referenced this pull request Apr 28, 2025
@yankcrime
Remove --cloud-provider argument from kube-apiserver
caa2d57 
As outlined in a recent Kubernetes 1.33 change [0], the
`--cloud-provider` flag has been removed from `kube-apiserver`.

[0] kubernetes/kubernetes#130162
@yankcrime yankcrime mentioned this pull request Apr 28, 2025
Merged
yankcrime added a commit to nscaledev/uni-helm-cluster-api that referenced this pull request Apr 29, 2025
@yankcrime
Remove --cloud-provider argument from kube-apiserver
1b9a0f9 
As outlined in a recent Kubernetes 1.33 change [0], the
`--cloud-provider` flag has been removed from `kube-apiserver`.

[0] kubernetes/kubernetes#130162
spjmurray pushed a commit to nscaledev/uni-helm-cluster-api that referenced this pull request Apr 29, 2025
@yankcrime
Remove --cloud-provider argument from kube-apiserver (#34)
82e8e46 
As outlined in a recent Kubernetes 1.33 change [0], the
`--cloud-provider` flag has been removed from `kube-apiserver`.

[0] kubernetes/kubernetes#130162
@AkihiroSuda AkihiroSuda mentioned this pull request May 1, 2025
Merged
@brandond brandond mentioned this pull request May 5, 2025
Closed
@carlory carlory mentioned this pull request May 6, 2025
Open
@jxadl jxadl mentioned this pull request May 27, 2025
Closed
@nilo19 nilo19 mentioned this pull request Jun 4, 2025
Merged
@Karthik-K-N Karthik-K-N mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@hashim21223445 hashim21223445 hashim21223445 approved these changes

@logicalhan logicalhan Awaiting requested review from logicalhan

@sttts sttts Awaiting requested review from sttts

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@elmiko elmiko

@sttts sttts

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.