Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/klog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.110.1
Choose a base ref
...
head repository: kubernetes/klog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.120.1
Choose a head ref
  • 11 commits
  • 17 files changed
  • 3 contributors

Commits on Nov 15, 2023

  1. OWNERS: remove serathius, add mengjiao-liu, promote pohly

    Serathius is focused on etcd these days, we shouldn't rely on him anymore for
    approvals. Mengjiao has been very active with logging and would be a good
    addition to the pool of reviewers.
    
    I myself (pohly) have been the de-facto maintainer. Being able to approve
    changes from others will be useful and I'll be careful to get a
    second approver for my own changes.
    pohly committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f33bd6c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #394 from pohly/owners-update

    OWNERS: remove serathius, add mengjiao-liu, promote pohly
    k8s-ci-robot authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    761b630 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. docs: clarify relationship between different features

    With klogr being deprecated there might be some confusion whether
    textlogger or klog.Background should be used instead.
    pohly committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d3dd725 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #395 from pohly/readme-update

    docs: clarify relationship between different features
    k8s-ci-robot authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8dd3f2e View commit details
    Browse the repository at this point in the history
  3. Add SafePtr wrapper

    kaisoz committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    881fa0b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #393 from kaisoz/add-safeptr

    Add SafePtr wrapper
    k8s-ci-robot authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2086216 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. dependencies: logr v1.4.1

    This moves slog support into the main package. Go >1.18 is needed for generic
    type parameters.
    pohly committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    39afdba View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. add SetSlogLogger

    This is syntactic sugar, but it's still useful because it hides logr from
    developers who only care about klog and slog.
    pohly committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5d1d2d5 View commit details
    Browse the repository at this point in the history
  2. slog: use main logr package instead of logr/slogr

    logr v1.4.0 moved the slog support functions in the main package and deprecated
    slogr.
    pohly committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e4deee8 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge pull request #396 from pohly/slog-helper

    logr v1.4.1 + SetSlogLogger
    k8s-ci-robot authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    2d08296 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. textlogger: allow caller to override stack unwinding

    One use case is to use Ginkgo for stack unwinding. Then `ginkgo.GingkgoHelper`
    also works for log output, not just for E2E failures.
    pohly authored and dims committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    007e661 View commit details
    Browse the repository at this point in the history
Loading