WIP: Support cluster-api for non-master instancegroups, on GCE #8151

justinsb · 2019-12-18T14:02:06Z

No description provided.

justinsb · 2019-12-22T17:44:35Z

Will be building this up here and then splitting out smaller pieces (e.g. #8180). This PR will show the "big picture" and hopefully there will be manageable pieces that make sense individually!

johngmyers · 2019-12-22T20:05:49Z

Makefile

@@ -168,6 +168,7 @@ kops: ${KOPS}
 ${KOPS}: ${BINDATA_TARGETS}
 	go build ${GCFLAGS} ${EXTRA_BUILDFLAGS} ${LDFLAGS}"-X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA} ${EXTRA_LDFLAGS}" -o $@ k8s.io/kops/cmd/kops/

+.PHONY: ${GOBINDATA}


Why? This task actually creates/updates the file that ${GOBINDATA} expands to, so it's not phony.

You're right - fixed!

johngmyers · 2019-12-22T23:40:26Z

It's currently not possible to turn off MachineDeployment's rolling updates. I filed kubernetes-sigs/cluster-api#1754 but that appears to have been kicked into the long grass.

Kops rolling updates are soon to be much more sophisticated than MachineDeployment's. You might want to use MachineSets instead of MachineDeployments.

mitch000001 · 2019-12-23T14:36:36Z

pkg/model/gcemodel/autoscalinggroup.go

+					"bootstrap": map[string]interface{}{
+						"dataSecretName": dataSecretName,
+					},
+					"infrastructureRef": map[string]interface{}{


I assume you're using these maps to avoid the dependency of Cluster API repo, right?

Right - it's actually not so much a circular dependency as it is that cluster-api has its own dependencies on controller-runtime & client-go etc and I was hitting conflicts.

We want to start re-using it for cluster-api support.

This is the first step to supporting cluster-api; starting with GCE for now. Slight problem at the moment: kubernetes/kubernetes#86509

fejta-bot · 2020-07-09T04:29:05Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2020-07-09T04:29:12Z

@justinsb: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mitch000001 · 2020-07-26T13:42:28Z

cmd/kops-controller/controllers/instancegroup_controller.go

+
+	var resource string
+
+	switch gvk.Group + ":" + gvk.Kind {


Is there any way we can put this logic into something generic? To me it seems that this switch will expand pretty fast once we have more providers implementing this logic. And then we have two places worrying about which cloud uses which resources, which is quite unfortunate.

It looks like this is essentially a map lookup.

fejta-bot · 2020-09-17T06:46:53Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-10-17T07:29:43Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-10-17T07:29:55Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

justinsb · 2021-03-21T15:18:10Z

Going to reopen, but leave as WIP, as I track merging this functionality.

k8s-ci-robot · 2021-03-21T15:18:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from justinsb after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-03-21T15:18:58Z

@justinsb: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kops-verify-generated	`7713746`	link	`/test pull-kops-verify-generated`
pull-kops-verify-gofmt	`7713746`	link	`/test pull-kops-verify-gofmt`
pull-kops-bazel-test	`7713746`	link	`/test pull-kops-bazel-test`
pull-kops-e2e-k8s-containerd	`7713746`	link	`/test pull-kops-e2e-k8s-containerd`
pull-kops-bazel-build	`7713746`	link	`/test pull-kops-bazel-build`
pull-kops-verify-gomod	`7713746`	link	`/test pull-kops-verify-gomod`
pull-kops-verify-staticcheck	`7713746`	link	`/test pull-kops-verify-staticcheck`
pull-kops-verify-bazel	`7713746`	link	`/test pull-kops-verify-bazel`
pull-kops-verify-govet	`7713746`	link	`/test pull-kops-verify-govet`
pull-kops-e2e-kubernetes-aws	`7713746`	link	`/test pull-kops-e2e-kubernetes-aws`
pull-kops-verify-boilerplate	`7713746`	link	`/test pull-kops-verify-boilerplate`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

olemarkus · 2021-04-08T07:22:41Z

/milestone v1.22

fejta-bot · 2021-05-08T08:04:38Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

k8s-ci-robot · 2021-05-08T08:04:47Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2019

k8s-ci-robot requested review from drekle and joshbranham December 18, 2019 14:02

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019

justinsb force-pushed the kops_clusterapi branch from 1641714 to 4538868 Compare December 22, 2019 17:43

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 22, 2019

justinsb force-pushed the kops_clusterapi branch from c8379eb to 97659b2 Compare December 22, 2019 18:44

johngmyers reviewed Dec 22, 2019

View reviewed changes

mitch000001 reviewed Dec 23, 2019

View reviewed changes

justinsb mentioned this pull request Dec 24, 2019

WIP: cluster-api - boot nodes without state store access #8198

Closed

justinsb force-pushed the kops_clusterapi branch from 97659b2 to 9e82b69 Compare January 11, 2020 19:55

justinsb added 6 commits January 11, 2020 23:21

Starting on docs

ff591fb

Refactor: Clean up apply logic to be more modular

318a420

We want to start re-using it for cluster-api support.

gce: Back kops InstanceGroup CRDs with MachineDeployments

86741ca

This is the first step to supporting cluster-api; starting with GCE for now. Slight problem at the moment: kubernetes/kubernetes#86509

autogen: bazel & vendor

63089b7

more dev docs

31b9fa1

Reformat to simplify diff

7713746

justinsb force-pushed the kops_clusterapi branch from 9e82b69 to 7713746 Compare January 12, 2020 04:33

rifelpet mentioned this pull request Jan 29, 2020

kops-controller using the cluster-api #7005

Closed

justinsb added this to the v1.19 milestone Apr 10, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2020

mitch000001 reviewed Jul 26, 2020

View reviewed changes

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2020

k8s-ci-robot closed this Oct 17, 2020

justinsb reopened this Mar 21, 2021

k8s-ci-robot added area/addons area/documentation labels Mar 21, 2021

k8s-ci-robot added area/kops-controller and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2021

k8s-ci-robot modified the milestones: v1.19, v1.22 Apr 8, 2021

k8s-ci-robot closed this May 8, 2021

WIP: Support cluster-api for non-master instancegroups, on GCE #8151

WIP: Support cluster-api for non-master instancegroups, on GCE #8151

Uh oh!

Conversation

justinsb commented Dec 18, 2019

Uh oh!

justinsb commented Dec 22, 2019

Uh oh!

johngmyers Dec 22, 2019

Choose a reason for hiding this comment

Uh oh!

justinsb Jan 12, 2020

Choose a reason for hiding this comment

Uh oh!

johngmyers commented Dec 22, 2019

Uh oh!

mitch000001 Dec 23, 2019

Choose a reason for hiding this comment

Uh oh!

justinsb Jan 12, 2020

Choose a reason for hiding this comment

Uh oh!

fejta-bot commented Jul 9, 2020

Uh oh!

k8s-ci-robot commented Jul 9, 2020

Uh oh!

mitch000001 Jul 26, 2020

Choose a reason for hiding this comment

Uh oh!

johngmyers Jul 26, 2020

Choose a reason for hiding this comment

Uh oh!

fejta-bot commented Sep 17, 2020

Uh oh!

fejta-bot commented Oct 17, 2020

Uh oh!

k8s-ci-robot commented Oct 17, 2020

Uh oh!

justinsb commented Mar 21, 2021

Uh oh!

k8s-ci-robot commented Mar 21, 2021

Uh oh!

k8s-ci-robot commented Mar 21, 2021

Uh oh!

olemarkus commented Apr 8, 2021

Uh oh!

fejta-bot commented May 8, 2021

Uh oh!

k8s-ci-robot commented May 8, 2021

Uh oh!

Uh oh!