Skip to content

Automated cherry pick of #9794 and #10138 onto release-1.19 #10134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 29, 2020
Merged

Automated cherry pick of #9794 and #10138 onto release-1.19 #10134

merged 10 commits into from
Oct 29, 2020

Conversation

rdrgmnzs
Copy link
Contributor

@rdrgmnzs rdrgmnzs commented Oct 29, 2020 •
edited
Loading

Automated cherry pick of #9794 and #10138 onto release-1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2020
@hakman
Copy link
Member

hakman commented Oct 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@hakman
Copy link
Member

hakman commented Oct 29, 2020 •
edited
Loading

Noticed this this morning when creating a cluster with spec.api.loadBalancer.type: Public set:

I1029 08:32:10.951280    8779 executor.go:103] Tasks: 97 done / 98 total; 1 can run
W1029 08:32:12.256390    8779 executor.go:131] error running task "AutoscalingGroup/master-a.masters.test.example.com" (4m50s remaining to succeed): 
error creating AutoScalingGroup: Provided Load Balancers may not be valid. Please ensure they exist and try again.
I1029 08:32:12.256447    8779 executor.go:147] No progress made, sleeping before retrying 1 task(s)

/hold
/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet October 29, 2020 06:48
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@rifelpet
Copy link
Member

Did it eventually succeed? We might just need to setup the ASG task to depend on any load balancers or target groups it's attaching to. If it didn't eventually succeed then this is a bigger problem

@hakman
Copy link
Member

hakman commented Oct 29, 2020

It never succeeded. Not on next runs either.

@rifelpet rifelpet mentioned this pull request Oct 29, 2020
Merged
@hakman hakman removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@rifelpet
Attach/detach TGs from ASGs when using direct target
d0f3286
@rifelpet
Lookup LoadBalancerName when only the LB task name is known
446561b
@rifelpet
Ignore changes reported by subsequent updates
792f179 
Usually this is an "actual.Foo = e.Foo" one-liner but we don't know which LB attached to an ASG is the API ELB so it's a bit more complicated
@rdrgmnzs rdrgmnzs changed the title Automated cherry pick of #9794 onto release-1.19 Automated cherry pick of #9794 and #10138 onto release-1.19 Oct 29, 2020
@hakman
Copy link
Member

hakman commented Oct 29, 2020

@rifelpet feel free to merge this when ready.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 72bfb1d into kubernetes:release-1.19 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rifelpet rifelpet

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@rdrgmnzs @k8s-ci-robot @hakman @rifelpet