Skip to content

Automated cherry pick of #10048: Install container runtime packages as assets #10123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 28, 2020
Merged

Automated cherry pick of #10048: Install container runtime packages as assets #10123

merged 5 commits into from
Oct 28, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 27, 2020

Cherry pick of #10048 on release-1.19.

#10048: Install container runtime packages as assets - Main

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2020
@hakman hakman changed the title Automated cherry pick of #10048: Install container runtime packages as assets - Main Automated cherry pick of #10048: Install container runtime packages as assets Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@johngmyers
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@johngmyers
Copy link
Member

Holding for #10122

@hakman
Copy link
Member Author

hakman commented Oct 28, 2020

@johngmyers #10122 is just a question of building some new kope.io images and @justinsb said he will do that soon. Waiting for that to merge will most likely add conflicts.
Also, there is an easy way around this by using the official Debian image 379101102735/debian-stretch-hvm-x86_64-gp2-2020-07-20-58035.

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@hakman
Copy link
Member Author

hakman commented Oct 28, 2020 •
edited
Loading

Thanks @johngmyers :)

@k8s-ci-robot k8s-ci-robot merged commit a2e4009 into kubernetes:release-1.19 Oct 28, 2020
@hakman hakman deleted the automated-cherry-pick-of-#10048-upstream-release-1.19 branch October 30, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @johngmyers