Skip to content

Conversation

rifelpet
Copy link
Member

A recent sdk update added _Values() functions that return a list of all enums for given values. This updates the API validation's hardcoded lists of strings to instead use these functions.

const (
	// InstanceInterruptionBehaviorHibernate is a InstanceInterruptionBehavior enum value
	InstanceInterruptionBehaviorHibernate = "hibernate"

	// InstanceInterruptionBehaviorStop is a InstanceInterruptionBehavior enum value
	InstanceInterruptionBehaviorStop = "stop"

	// InstanceInterruptionBehaviorTerminate is a InstanceInterruptionBehavior enum value
	InstanceInterruptionBehaviorTerminate = "terminate"
)

// InstanceInterruptionBehavior_Values returns all elements of the InstanceInterruptionBehavior enum
func InstanceInterruptionBehavior_Values() []string {
	return []string{
		InstanceInterruptionBehaviorHibernate,
		InstanceInterruptionBehaviorStop,
		InstanceInterruptionBehaviorTerminate,
	}
}

...

const (
	// TenancyDefault is a Tenancy enum value
	TenancyDefault = "default"

	// TenancyDedicated is a Tenancy enum value
	TenancyDedicated = "dedicated"

	// TenancyHost is a Tenancy enum value
	TenancyHost = "host"
)

// Tenancy_Values returns all elements of the Tenancy enum
func Tenancy_Values() []string {
	return []string{
		TenancyDefault,
		TenancyDedicated,
		TenancyHost,
	}
}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/api approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2020
@olemarkus
Copy link
Member

Nice find. Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit abd86af into kubernetes:master Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 20, 2020
@rifelpet rifelpet deleted the instance-interruption-validation branch October 29, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants