Skip to content

upgrade-cluster: test that new image in stable or alpha channel will … #10052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2020
Merged

upgrade-cluster: test that new image in stable or alpha channel will … #10052

merged 2 commits into from
Oct 14, 2020

Conversation

nvanheuverzwijn
Copy link
Contributor

@nvanheuverzwijn nvanheuverzwijn commented Oct 14, 2020 •
edited by hakman
Loading

This PR adds a test to make sure that stable and alpha channel image will receive proper updates when running kops upgrade cluster. This test will fail if image channel changes without adding the proper prefix in HasUpstreamImagePrefix function.

Example of failed test :

=== RUN   TestStableChannel
--- FAIL: TestStableChannel (0.00s)
    integration_test.go:410: Stable image '099720109477/ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20200907' has not a recognized prefix. Add the correct prefix to HasUpstreamImagePrefix function
=== RUN   TestAlphaChannel
--- FAIL: TestAlphaChannel (0.00s)
    integration_test.go:430: Alpha image channel '099720109477/ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20200907' has not a recognized prefix. Add the correct prefix to HasUpstreamImagePrefix function
FAIL
FAIL	k8s.io/kops/tests/integration/channel	0.023s
FAIL

Fixes: #10021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @nvanheuverzwijn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2020
@nvanheuverzwijn
Copy link
Contributor Author

@hakman This would be it

@nvanheuverzwijn nvanheuverzwijn force-pushed the add-test-cluster-upgrade branch from 27d89c7 to b0fd89a Compare October 14, 2020 14:14
@hakman
Copy link
Member

hakman commented Oct 14, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2020
hakman
hakman requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @nvanheuverzwijn. Just a minor change in the new test and should be good to go.

@nvanheuverzwijn @hakman
Update tests/integration/channel/integration_test.go
5f59b86 
Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
@nvanheuverzwijn
Copy link
Contributor Author

Thank you @hakman

@hakman
Copy link
Member

hakman commented Oct 14, 2020

Thanks for sticking with this @nvanheuverzwijn.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, nvanheuverzwijn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6611e53 into kubernetes:master Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 14, 2020
@nvanheuverzwijn nvanheuverzwijn deleted the add-test-cluster-upgrade branch October 14, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

kops upgrade image requires kope.io
3 participants
@nvanheuverzwijn @k8s-ci-robot @hakman