Skip to content

Add some missing notes to the release notes #10056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2020
Merged

Add some missing notes to the release notes #10056

merged 3 commits into from
Oct 18, 2020

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2020
@olemarkus olemarkus force-pushed the docs-restructure-relnotes branch from 4980c71 to c849274 Compare October 15, 2020 07:09
hakman
hakman requested changes Oct 17, 2020
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also change the section title to ## Other significant changes by kind and add ### General or something similar for the first section.

@olemarkus @hakman
Apply suggestions from code review
f114b61 
Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
hakman
hakman reviewed Oct 18, 2020
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small tweak.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2020
@hakman hakman added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2020
@hakman
Copy link
Member

hakman commented Oct 18, 2020

Thanks @olemarkus :)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0be8d4e into kubernetes:master Oct 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@olemarkus @hakman @k8s-ci-robot