Skip to content

Conversation

sats-23
Copy link
Contributor

@sats-23 sats-23 commented Jul 27, 2025

Fixes #17496

@k8s-ci-robot k8s-ci-robot requested a review from hakman July 27, 2025 07:40
@k8s-ci-robot k8s-ci-robot requested a review from zetaab July 27, 2025 07:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sats-23. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Jul 27, 2025

Thank you @sats-23! Would you mind changing this to the full image, not just the tag?
Also, why change from headless to driver?

@sats-23 sats-23 force-pushed the sup-image-tag branch 2 times, most recently from 0d5d200 to cf65d92 Compare July 27, 2025 08:22
@sats-23 sats-23 changed the title Add support for passing image tag for nvidia-k8s-device-plgin Add support for passing image for nvidia-k8s-device-plugin Jul 27, 2025
@sats-23
Copy link
Contributor Author

sats-23 commented Jul 27, 2025

Thank you @sats-23! Would you mind changing this to the full image, not just the tag? Also, why change from headless to driver?

Hi @hakman, thank you for the comments.

  1. I have made the changes to support the full image, please refer: cf65d92

  2. The Nvidia driver was constantly upgraded and the current version used is nvidia-driver-535-server.
    Refer:

    const NvidiaDefaultDriverPackage = "nvidia-driver-535-server"

    While the driver kept up with the updates, the comments were still referencing the old driver version, so I just updated those to reflect the current usage.

@hakman
Copy link
Member

hakman commented Jul 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2025
@sats-23
Copy link
Contributor Author

sats-23 commented Jul 27, 2025

/retest

1 similar comment
@hakman
Copy link
Member

hakman commented Jul 27, 2025

/retest

@hakman
Copy link
Member

hakman commented Jul 27, 2025

@sats-23 this LGTM, so pretty much just the tests need to finish running.
Would you mind also squashing the commits, it makes it easier to cherry-pick.
Thanks!

@sats-23
Copy link
Contributor Author

sats-23 commented Jul 27, 2025

@sats-23 this LGTM, so pretty much just the tests need to finish running. Would you mind also squashing the commits, it makes it easier to cherry-pick. Thanks!

Thank you for the feedback, I have squashed all commits.

@hakman
Copy link
Member

hakman commented Jul 27, 2025

Awesome! 🚀
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2025
@hakman
Copy link
Member

hakman commented Jul 27, 2025

/test pull-kops-e2e-gce-cni-calico
/retest

@hakman
Copy link
Member

hakman commented Jul 27, 2025

/retest

2 similar comments
@hakman
Copy link
Member

hakman commented Jul 27, 2025

/retest

@hakman
Copy link
Member

hakman commented Jul 27, 2025

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

3 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Jul 28, 2025

/test pull-kops-e2e-gce-cni-calico
/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Jul 28, 2025

/hold for fixing test failures

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
@sats-23
Copy link
Contributor Author

sats-23 commented Jul 29, 2025

/hold for fixing test failures

Hi @hakman
Is there any clue on the infra issues at the moment? Any pending action from my end?

@hakman
Copy link
Member

hakman commented Jul 29, 2025

Hi @sats-23

Is there any clue on the infra issues at the moment?

not yet

Any pending action from my end?

no

@hakman
Copy link
Member

hakman commented Jul 29, 2025

/test all
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2025
@hakman
Copy link
Member

hakman commented Jul 29, 2025

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-ipalias
/retest

@hakman
Copy link
Member

hakman commented Jul 29, 2025

/retest

@hakman
Copy link
Member

hakman commented Jul 29, 2025

/override pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-amazonvpc

In response to this:

/override pull-kops-e2e-cni-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@sats-23: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-gce-cni-calico 98090bc link false /test pull-kops-e2e-gce-cni-calico
pull-kops-e2e-cni-kuberouter 98090bc link false /test pull-kops-e2e-cni-kuberouter

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit f28b11c into kubernetes:master Jul 29, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing image tag version to nvidia k8s-device-plugin
4 participants