Skip to content

Conversation

rifelpet
Copy link
Member

Cherry pick of #17500 on release-1.33.

#17500: Fix invalid filters for describing security group rules

For details on the cherry pick process, see the cherry pick requests page.


The Describe SGR API doesn't support filtering by VPC ID or group name.
Therefore if we dont have a SG ID we'll just skip trying to delete SGRs
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jul 19, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider labels Jul 19, 2025
@k8s-ci-robot k8s-ci-robot requested review from hakman and olemarkus July 19, 2025 00:20
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2025
@hakman
Copy link
Member

hakman commented Jul 19, 2025

/retest

1 similar comment
@hakman
Copy link
Member

hakman commented Jul 19, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5d28c11 into kubernetes:release-1.33 Jul 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants