Skip to content

azure: Add defaults for network CIDR and subscription ID #17504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

azure: Add defaults for network CIDR and subscription ID #17504

merged 2 commits into from
Jul 20, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 20, 2025

/cc @ameukam

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot requested a review from ameukam July 20, 2025 05:54
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2025
@hakman hakman marked this pull request as ready for review July 20, 2025 05:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2025
@hakman
Copy link
Member Author

hakman commented Jul 20, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman
Copy link
Member Author

hakman commented Jul 20, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman hakman force-pushed the azure-test branch 2 times, most recently from f50b1bd to 743f59b Compare July 20, 2025 06:09
@hakman
Copy link
Member Author

hakman commented Jul 20, 2025

/test pull-kops-e2e-kubernetes-azure

1 similar comment
@hakman
Copy link
Member Author

hakman commented Jul 20, 2025

/test pull-kops-e2e-kubernetes-azure

ameukam
ameukam reviewed Jul 20, 2025
View reviewed changes
upup/pkg/fi/cloudup/defaults.go
return fmt.Errorf("unable to infer NetworkCIDR from Network ID, please specify --network-cidr")
}
} else {
c.Spec.Networking.NetworkCIDR = "10.0.0.0/16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to use a const for this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a cleanup there in a separate PR, for now don't want to change the style.

@hakman hakman requested a review from ameukam July 20, 2025 10:16
@ameukam
Copy link
Member

ameukam commented Jul 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2025
@hakman
Copy link
Member Author

hakman commented Jul 20, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1a0d074 into kubernetes:master Jul 20, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @ameukam