-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Introduce flag use-kubeconfig which allows loading from the local kubeconfig #17494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…econfig This supports workflows that modify the local kubeconfig for advanced configurations, which were accidentally broken by trying to always generate the config. Issue kubernetes#17262
|
||
clusterName := cluster.ObjectMeta.Name | ||
|
||
clientGetter := genericclioptions.NewConfigFlags(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is restoring the prior logic, which was in 324117c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as discussed during Office Hours.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/override pull-kops-e2e-k8s-gce-ipalias |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-kops-e2e-k8s-aws-amazonvpc |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This supports workflows that modify the local kubeconfig for advanced configurations,
which were accidentally broken by trying to always generate the config.
Issue #17262