Skip to content

Makefile: correct .PHONY casing #17442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Makefile: correct .PHONY casing #17442

merged 1 commit into from
Jun 18, 2025

Conversation

mohiuddin-khan-shiam
Copy link
Contributor

The channels-install and nodeup-install rules were mistakenly declared with a lowercase .phony directive.
Only the uppercase special target .PHONY tells GNU make to run the rule unconditionally; with the typo, the targets could be skipped if files named channels-install or nodeup-install existed, breaking local builds or CI.

This patch capitalises the directive:

  • .PHONY: channels-install
  • .PHONY: nodeup-install

Restores proper phony-target behaviour and guarantees reliable installation of the channels and nodeup binaries.

@mohiuddin-khan-shiam
Makefile: correct .PHONY casing
a08f34f 
The `channels-install` and `nodeup-install` rules were mistakenly declared with a lowercase `.phony` directive.
Only the uppercase special target `.PHONY` tells GNU make to run the rule unconditionally; with the typo, the targets could be skipped if files named `channels-install` or `nodeup-install` existed, breaking local builds or CI.

This patch capitalises the directive:

* `.PHONY: channels-install`
* `.PHONY: nodeup-install`

Restores proper phony-target behaviour and guarantees reliable installation of the `channels` and `nodeup` binaries.
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 17, 2025 •
edited
Loading

CLA Signed

  • ✅login: mohiuddin-khan-shiam / (a08f34f)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab June 17, 2025 19:58
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @mohiuddin-khan-shiam!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mohiuddin-khan-shiam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 18, 2025
@hakman
Copy link
Member

hakman commented Jun 18, 2025

Thanks @mohiuddin-khan-shiam!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@hakman
Copy link
Member

hakman commented Jun 18, 2025

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit d424dad into kubernetes:master Jun 18, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 18, 2025
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@mohiuddin-khan-shiam @k8s-ci-robot @hakman @rifelpet