Skip to content

GCE: set node labels and taints as autoscaler env vars #17434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

GCE: set node labels and taints as autoscaler env vars #17434

merged 3 commits into from
Jul 3, 2025

Conversation

flopib
Copy link
Contributor

@flopib flopib commented Jun 12, 2025

This proposed change sets InstanceGroup node labels and taints in kube-env on GCP, so that autoscaler can make a scale-up decision based on taints and tolerations, and that the resulting node has the labels set.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @flopib. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2025
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Jun 12, 2025
@rifelpet
Copy link
Member

Thanks @flopib, can you add a test case for this? You can add some example node labels and taints to this instance group, run ./hack/update-expected.sh, and commit all the changes.

@flopib
Copy link
Contributor Author

flopib commented Jul 1, 2025

Can this be looked into again? The requested changes should be implemented.

@rifelpet
Copy link
Member

rifelpet commented Jul 1, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2025
@rifelpet
Copy link
Member

rifelpet commented Jul 1, 2025

The verify-terraform CI failure is from the most recent updates in hashicorp/terraform-provider-aws#43213

Once resolved we can rerun the job

@rifelpet
Copy link
Member

rifelpet commented Jul 1, 2025

/retest

rifelpet
rifelpet reviewed Jul 1, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2025
@rifelpet
Copy link
Member

rifelpet commented Jul 3, 2025

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@hakman
Copy link
Member

hakman commented Jul 3, 2025

/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 8502cca into kubernetes:master Jul 3, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jul 3, 2025
@flopib flopib deleted the gce-mig-autoscaler-metadata branch July 4, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@flopib @k8s-ci-robot @rifelpet @hakman