Skip to content

gce: set values for role labels #17378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

gce: set values for role labels #17378

merged 2 commits into from
Apr 28, 2025

Conversation

justinsb
Copy link
Member

This seems to be required to keep terraform from always recreating
the instancegroup configuration (though that is likely a TF bug)

@justinsb
gce: set values for role labels
51a58f4 
This seems to be required to keep terraform from always recreating
the instancegroup configuration (though that is likely a TF bug)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider labels Apr 27, 2025
@justinsb
Copy link
Member Author

Example permadiff without this PR:

  # google_compute_instance_template.nodes-us-east4-a-foo-k8s-local must be replaced
+/- resource "google_compute_instance_template" "nodes-us-east4-a-foo-k8s-local" {
      ~ creation_timestamp   = "2025-04-27T14:12:24.315-07:00" -> (known after apply)
      ~ effective_labels     = { # forces replacement
          + "k8s-io-role-node"           = (known after apply)
            # (3 unchanged elements hidden)
        }
...

@justinsb
Copy link
Member Author

Assuming we merge this, I don't think we should backport this (or at least not very far) because it will force a rolling-update for everyone (including non-terraform users).

@justinsb justinsb mentioned this pull request Apr 27, 2025
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2025
@hakman
Copy link
Member

hakman commented Apr 28, 2025

/retest

1 similar comment
@hakman
Copy link
Member

hakman commented Apr 28, 2025

/retest

@hakman
Copy link
Member

hakman commented Apr 28, 2025

/override pull-kops-e2e-k8s-aws-amazonvpc

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit f5f48d3 into kubernetes:master Apr 28, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Apr 28, 2025
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @k8s-ci-robot @hakman @rifelpet