Skip to content

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Apr 7, 2025

Ensure kops toolbox enroll verify if SSH keys are loaded before authenticate to the host.

Ensure `kops toolbox enroll` verify if SSH keys are loaded before
authenticate to the host.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from hakman and olemarkus April 7, 2025 20:17
@ameukam
Copy link
Member Author

ameukam commented Apr 7, 2025

cc @justinsb @hakman @rifelpet

@hakman
Copy link
Member

hakman commented Apr 8, 2025

/retest

1 similar comment
@ameukam
Copy link
Member Author

ameukam commented Apr 8, 2025

/retest

@rifelpet
Copy link
Member

rifelpet commented Apr 8, 2025

I'm surprised that kubetest2-kops isn't running a kops delete cluster at the beginning to tear down any resources left over from previous presubmit jobs in this PR

@hakman
Copy link
Member

hakman commented Apr 9, 2025

/retest

@hakman
Copy link
Member

hakman commented Apr 9, 2025

/test all

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@hakman
Copy link
Member

hakman commented Apr 9, 2025

/test pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot k8s-ci-robot merged commit c23b108 into kubernetes:master Apr 9, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Apr 9, 2025
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants