Skip to content

ServiceTrafficDistribution cannot be switched off for kubernetes master (for scalability tests) #17318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

ServiceTrafficDistribution cannot be switched off for kubernetes master (for scalability tests) #17318

merged 1 commit into from
Mar 19, 2025

Conversation

dims
Copy link
Member

@dims dims commented Mar 19, 2025 •
edited
Loading

Feature gate is GA now: kubernetes/kubernetes#130673

❯
❯ (find . -name kube-apiserver.log && find . -name kube-proxy.log)
./1902072946013245440/artifacts/18.116.47.23/kube-apiserver.log
./1902072946013245440/artifacts/3.142.225.232/kube-apiserver.log
./1902072946013245440/artifacts/18.191.224.177/kube-apiserver.log
./1902072946013245440/artifacts/18.116.47.23/kube-proxy.log
./1902072946013245440/artifacts/3.142.225.232/kube-proxy.log
./1902072946013245440/artifacts/18.191.224.177/kube-proxy.log
❯ grep ServiceTrafficDistribution ./1902072946013245440/artifacts/18.116.47.23/kube-apiserver.log | head -1
E0318 19:14:31.778687      12 run.go:72] "command failed" err="cannot set feature gate ServiceTrafficDistribution to false, feature is locked to true"
❯ grep ServiceTrafficDistribution ./1902072946013245440/artifacts/18.116.47.23/kube-proxy.log | head -1
E0318 19:14:31.623058      12 run.go:72] "command failed" err="failed complete: cannot set feature gate ServiceTrafficDistribution to false, feature is locked to true"

@dims
ServiceTrafficDistribution cannot be switched off
5752000 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2025
@dims
Copy link
Member Author

dims commented Mar 19, 2025

/assign @hakuna-matatah @hakman @rifelpet

@dims dims changed the title ServiceTrafficDistribution cannot be switched off ServiceTrafficDistribution cannot be switched off for kubernetes master (for scalability tests) Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@hakuna-matatah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, hakuna-matatah, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member

hakman commented Mar 19, 2025

/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

In response to this:

/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit a58ee14 into kubernetes:master Mar 19, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Mar 19, 2025
@dims dims mentioned this pull request Mar 19, 2025
Closed
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@hakman hakman hakman approved these changes

+1 more reviewer

@hakuna-matatah hakuna-matatah hakuna-matatah approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rifelpet rifelpet

@hakman hakman

@hakuna-matatah hakuna-matatah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @hakuna-matatah @k8s-ci-robot @hakman @rifelpet