Skip to content

Conversation

justinsb
Copy link
Member

This avoids the needs for these nodes to have access to the state store.

  • We no longer need S3/GCS credentials on the node.

  • We don't depend on S3/GCS being reachable from the control
    plane - at least here!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2025
@justinsb justinsb changed the title metal: copy control plane config to nodes WIP: metal: copy control plane config to nodes Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@justinsb
Copy link
Member Author

WIP because I'm starting by showing that the metal tests (at least) fail without the S3 credentials. The "real" PR was the one I pushed initially, and I'll push it again once we see the metal test fail. Hopefully things will then pass 😂

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@justinsb
Copy link
Member Author

Metal test failed (timed out) as expected when I stopped the credentials being copied, so now with the fix (copy all the files to the control plane nodes via SSH/SCP)

This avoids the needs for these nodes to have access to the state store.

* We no longer need S3/GCS credentials on the node.

* We don't depend on S3/GCS being reachable from the control
  plane - at least here!
@justinsb
Copy link
Member Author

Metal test passed, so removing the hack that stops credentials being uploaded.

@justinsb justinsb changed the title WIP: metal: copy control plane config to nodes metal: copy control plane config to nodes Feb 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@justinsb
Copy link
Member Author

Looks like metal test passed without the hack to stop passing credentials (as expected), so removing WIP

@hakman
Copy link
Member

hakman commented Feb 20, 2025

/test pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3b2b635 into kubernetes:master Feb 20, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 20, 2025
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants