-
Notifications
You must be signed in to change notification settings - Fork 4.7k
metal: copy control plane config to nodes #17273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eb84379
to
7d55475
Compare
WIP because I'm starting by showing that the metal tests (at least) fail without the S3 credentials. The "real" PR was the one I pushed initially, and I'll push it again once we see the metal test fail. Hopefully things will then pass 😂 |
Metal test failed (timed out) as expected when I stopped the credentials being copied, so now with the fix (copy all the files to the control plane nodes via SSH/SCP) |
This avoids the needs for these nodes to have access to the state store. * We no longer need S3/GCS credentials on the node. * We don't depend on S3/GCS being reachable from the control plane - at least here!
fb1bba2
to
beb5cc5
Compare
Metal test passed, so removing the hack that stops credentials being uploaded. |
Looks like metal test passed without the hack to stop passing credentials (as expected), so removing WIP |
/test pull-kops-e2e-k8s-aws-calico |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This avoids the needs for these nodes to have access to the state store.
We no longer need S3/GCS credentials on the node.
We don't depend on S3/GCS being reachable from the control
plane - at least here!