Skip to content

Remove default CPU limits for aws-iam-authentication and node-problem-detector #17237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

Remove default CPU limits for aws-iam-authentication and node-problem-detector #17237

merged 1 commit into from
Mar 1, 2025

Conversation

jim-barber-he
Copy link
Contributor

Remove the default CPU limits defined for the aws-iam-authentication and node-problem-detector DaemonSets.

This makes them behave the same as the other cpuLimit parameters for the cluster that also do not have defaults.

As it was previously set up, if an administrator does not want CPU limits defined for these DaemonSets, there was no way to define that via the cluster spec.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jim-barber-he. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/addons labels Jan 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab January 28, 2025 08:38
@jim-barber-he
Copy link
Contributor Author

I wrote this after talking about it a bit in Slack.
https://kubernetes.slack.com/archives/C3QUFP0QM/p1737422987782349

I don't know if the kOps maintainers are happy with applying this change or not, but I hope that they are.

@hakman
Copy link
Member

hakman commented Feb 1, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2025
@jim-barber-he
Copy link
Contributor Author

/retest

@jim-barber-he
Copy link
Contributor Author

Both times the tests say There are no nodes that your pod can schedule to
I guess these were for the calico and cilium additions tests based on the content above in this PR, which are not things my code changes touched?

@jim-barber-he
Copy link
Contributor Author

@hakman Do I just need to rebase against the master branch and push again or something?

@hakman
Copy link
Member

hakman commented Feb 4, 2025

No worries. Let me take a look this week when I get back to a laptop.

@jim-barber-he
Remove some default CPU limits
bdc25ad 
Remove the default CPU limits defined for the aws-iam-authentication and
node-problem-detector DaemonSets.

This makes them behave the same as the other `cpuLimit` parameters for
the cluster that also do not have defaults.

As it was previously set up, if an administrator does not want CPU
limits defined for these DaemonSets, there was no way to define that via
the cluster spec.
@jim-barber-he
Copy link
Contributor Author

/retest

@hakman hakman closed this Mar 1, 2025
@hakman hakman reopened this Mar 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2025
@jim-barber-he
Copy link
Contributor Author

jim-barber-he commented Mar 1, 2025 •
edited
Loading

Hi @hakman
The force push yesterday was me rebasing again the master branch again in the hopes the build would pass.

The tests are still failing, but the errors look like build infrastructure problems rather than anything to do with my change?
Let me know if I'm wrong with that, and what I might need to change to get this working.

Thanks.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2025 •
edited
Loading

@jim-barber-he: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons bdc25ad link false /test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Mar 1, 2025

/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

In response to this:

/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman hakman changed the title Remove some default CPU limits Remove default CPU limits for aws-iam-authentication and node-problem-detector Mar 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2d52403 into kubernetes:master Mar 1, 2025
26 of 27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Mar 1, 2025
@jim-barber-he jim-barber-he deleted the rm-cpu-limits branch March 5, 2025 04:53
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@jim-barber-he @k8s-ci-robot @hakman @rifelpet