Skip to content

Update Cilium to v1.16.1 #16800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 13, 2024
Merged

Update Cilium to v1.16.1 #16800

merged 7 commits into from
Sep 13, 2024

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Sep 2, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2024
@rifelpet
Copy link
Member Author

rifelpet commented Sep 2, 2024

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-cilium-etcd
/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-cilium-etcd
/test pull-kops-e2e-cni-cilium-eni

@rifelpet
Copy link
Member Author

rifelpet commented Sep 2, 2024

/test pull-kops-e2e-k8s-gce-cilium

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-cni-cilium

@hakman
Copy link
Member

hakman commented Sep 12, 2024

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-cilium-etcd
/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-cilium-etcd
/test pull-kops-e2e-cni-cilium-eni

@rifelpet
Copy link
Member Author

The ipv6 job is failing because cilium-operator isnt listening on the ipv6 loopback:

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/16800/pull-kops-e2e-cni-cilium-ipv6/1834091510740553728/artifacts/cluster-info/kube-system/events.yaml

  kind: Event
  metadata:
    creationTimestamp: "2024-09-12T05:09:12Z"
    name: cilium-operator-7497446677-gmnzj.17f466f34b5acb87
    namespace: kube-system
    resourceVersion: "215"
    uid: f18a95ce-d929-4e12-88c0-aaf1dc8f641f
  note: 'Liveness probe failed: Get "http://[::1]:9234/healthz": dial tcp [::1]:9234:
    connect: connection refused'

The documentation in cell.go here suggests it defaults to listening on both ipv4 and ipv6 loopback interfaces but the control plane host's /etc/hosts only resolves localhost to the ipv4 interface:

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/16800/pull-kops-e2e-cni-cilium-ipv6/1834091510740553728/artifacts/i-0b96dc146e0a65eda/etchosts

127.0.0.1 localhost

# The following lines are desirable for IPv6 capable hosts
::1 ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
ff02::3 ip6-allhosts

I'm going to try setting that cilium-config value to match our templating logic in the container probes.

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-cilium-etcd
/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-cilium-etcd
/test pull-kops-e2e-cni-cilium-eni

@rifelpet rifelpet marked this pull request as ready for review September 12, 2024 14:47
@rifelpet rifelpet changed the title WIP Update Cilium to v1.16.1 Update Cilium to v1.16.1 Sep 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from zetaab September 12, 2024 14:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@rifelpet
Copy link
Member Author

The last failures were flakes so this should be ready for a final review.

/test pull-kops-e2e-k8s-gce-cilium-etcd

@hakman
Copy link
Member

hakman commented Sep 12, 2024

/retest

@hakman
Copy link
Member

hakman commented Sep 12, 2024

/retest

hakman
hakman reviewed Sep 13, 2024
View reviewed changes
upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.16-v1.15.yaml.template
# helm template --release-name cilium cilium/cilium \
# --version 1.16.1 \
# --namespace kube-system \
# --values helm-values.yaml
{{ with .Networking.Cilium }}
{{ $semver := (trimPrefix "v" .Version) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: $semver and $operatorHealthPort may not be needed anymore either.

hakman
hakman approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🥳

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@hakman
Copy link
Member

hakman commented Sep 13, 2024

/override pull-kops-e2e-cni-cilium-eni

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-eni

In response to this:

/override pull-kops-e2e-cni-cilium-eni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 6a5f4e7 into kubernetes:master Sep 13, 2024
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Sep 13, 2024
@rifelpet rifelpet mentioned this pull request Sep 26, 2024
Merged
@raffis raffis mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@rifelpet @k8s-ci-robot @hakman