Skip to content

support to auto generate pod uuid #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

support to auto generate pod uuid #1874

merged 1 commit into from
Jul 24, 2025
+7 −2

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Jul 23, 2025 •
edited by saschagrunert
Loading

I want to create many pods to make some test.
crictl run --no-pull container.json pod.json
I have to set different uid in pod.json.
So I think we can support to auto generate pod uid if uid is empty in pod.json

Automatically generate the pod UUID if not provided by the JSON.

@ningmingxiao
support to auto generate pod uuid
c0a1662 
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer July 23, 2025 04:29
@k8s-ci-robot
Copy link
Contributor

Welcome @ningmingxiao!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ningmingxiao, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6e89762 into kubernetes-sigs:master Jul 24, 2025
49 of 51 checks passed
@ningmingxiao ningmingxiao deleted the add_uuid branch July 24, 2025 14:23
@saschagrunert saschagrunert added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 21, 2025
@github-actions github-actions bot mentioned this pull request Aug 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ningmingxiao @k8s-ci-robot @saschagrunert