Support websocket connections in critest
#1862
Merged
+116
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new test flags to be able to utilize websocket connections for the streaming server. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
48e89c8 to
86334ba
Compare
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
|
what would you think of using a flag to toggle, similar to crictl? |
I assume this comment was intended for the CRI-O PR? If so: yes sure. |
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
1 similar comment
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding new test flags to be able to utilize websocket connections for the streaming server.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refers to kubernetes/enhancements#4006
Does this PR introduce a user-facing change?