Add metricdescs subcommand for ListMetricDescriptors API #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e80437 to
e19bfe6
Compare
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
e19bfe6 to
b00094d
Compare
saschagrunert
approved these changes
Apr 22, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
There's no subcommand for ListMetricDescriptors https://github.com/kubernetes/cri-api/blob/c9a9c280d8500241d4e0ca04c28fa19974147108/pkg/apis/runtime/v1/api.proto#L130 .
When CRI can return metrics, this feature would be useful to know what kind of metrics can be retrieved via CRI.
I'm open to changing the subcommand name.
Server implementations:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?