Skip to content

Add support for OpenTelemetry traces #1317

New issue
New issue
Closed
#1319
Closed
Add support for OpenTelemetry traces#1317
#1319
@saschagrunert

Description

@saschagrunert
saschagrunert
opened on Dec 14, 2023

We're calling the runtime and image service setup from the kubelet in:

cri-tools/cmd/crictl/main.go

Line 82 in 6e004d1

res, err = remote.NewRemoteRuntimeService(endPoint, t, nil)

cri-tools/cmd/crictl/main.go

Line 93 in 6e004d1

return remote.NewRemoteRuntimeService(RuntimeEndpoint, t, nil)

cri-tools/cmd/crictl/main.go

Line 118 in 6e004d1

res, err = remote.NewRemoteImageService(endPoint, Timeout, nil)

cri-tools/cmd/crictl/main.go

Line 129 in 6e004d1

return remote.NewRemoteImageService(ImageEndpoint, Timeout, nil)

but we always pass a nil tracer provider to the service, which could be something to support OTEL in crictl.

The kubelet feature itself is enabled by default:

cri-tools/vendor/k8s.io/kubernetes/pkg/kubelet/cri/remote/remote_runtime.go

Lines 93 to 103 in 6e004d1

if utilfeature.DefaultFeatureGate.Enabled(features.KubeletTracing) {
tracingOpts := []otelgrpc.Option{
otelgrpc.WithPropagators(tracing.Propagators()),
otelgrpc.WithTracerProvider(tp),
}
// Even if there is no TracerProvider, the otelgrpc still handles context propagation.
// See https://github.com/open-telemetry/opentelemetry-go/tree/main/example/passthrough
dialOpts = append(dialOpts,
grpc.WithUnaryInterceptor(otelgrpc.UnaryClientInterceptor(tracingOpts...)),
grpc.WithStreamInterceptor(otelgrpc.StreamClientInterceptor(tracingOpts...)))
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions