UI: Handle missing TrialTemplates #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
andreyvelich
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Thank you for this fix @kimwnasptd.
Just small comment from me.
...eta1/frontend/src/app/pages/experiment-creation/trial-template/trial-template.component.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
andreyvelich
reviewed
Sep 6, 2021
There was a problem hiding this comment.
/lgtm
/approve
@kimwnasptd Please can you cherry-pick this commit on release-0.12 branch ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kimwnasptd
added a commit
to arrikto/katib
that referenced
this pull request
Sep 6, 2021
* Use YAML input if TrialParams are missing Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Separate TrialTemplates in two words Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1620
This is also part of the 0.12 release effort #1597
The UI should gracefully handle the case of missing TrialParameters.
I changed the UI to use
yamlinput by default and if no TrialTemplates were found then theConfigMapoption would be disabled. If the TrialTemplates were fetched correctly, and are not an empty list, then the UI will select theConfigMapoption.Checklist:
/cc @andreyvelich
/assign @kimwnasptd