Skip to content
This repository was archived by the owner on Sep 12, 2023. It is now read-only.
This repository was archived by the owner on Sep 12, 2023. It is now read-only.

Use fully-qualified labels #148

@alculquicondor

Description

@alculquicondor

Pods created with kubeflow controllers get some labels https://github.com/kubeflow/common/blob/master/pkg/apis/common/v1/constants.go

It is common practice in k8s to add a domain to the label name. This should reduce the chances of collision with user-defined labels. Then, the labels should go from:

  • replica-index to kubeflow.org/replica-index
  • replica-type to kubeflow.org/replica-type
  • replica-group to kubeflow.org/replica-group (although we could take the chance to rename this to kubeflow.org/operator-name with possible values tf-operator, mpi-operator and so on)
  • job-name to kubeflow.org/job-name
  • job-role to kubeflow.org/job-role (how does this differ from replica-type?)

This should enhance visibility and make it easier for cluster administrators to track the usage of operators in the cluster.

The way we can implement this is to start adding both existent and new labels to newly created pods, and change the have something like this in the constants.go file:

const ReplicaIndexLabelDeprecated = "replica-index"
const ReplicaIndexLabel           = "kubeflow.org/replica-index"

Then, we would remove the Deprecated variables after a few releases

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions