Skip to content

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented May 8, 2023

What type of PR is this?

/kind optimize

What this PR does / why we need it:

添加 pkg 命令行参数,可以覆盖默认的 deploy-config, 用来支持添加异构的 agent 节点

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2023
@x893675
Copy link
Collaborator Author

x893675 commented May 8, 2023

/kind optimize

@codecov-commenter
Copy link

Codecov Report

Merging #577 (d53fd5e) into master (9697b94) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   14.03%   14.03%           
=======================================
  Files         138      138           
  Lines       19503    19503           
=======================================
  Hits         2738     2738           
  Misses      16469    16469           
  Partials      296      296           

@x893675
Copy link
Collaborator Author

x893675 commented May 8, 2023

/cc @zhuzhenfan

@kubeclipper-bot kubeclipper-bot requested a review from zhuzhenfan May 8, 2023 08:06
@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5c70e5f2b9ef782362ad65c9aaa723398da11e44

@kubeclipper-bot kubeclipper-bot merged commit 6982d82 into kubeclipper:master May 8, 2023
@x893675 x893675 mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/optimize lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants