Skip to content

Conversation

lyp256
Copy link
Contributor

@lyp256 lyp256 commented Nov 2, 2022

/kind bug

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2022
Signed-off-by: lyp256 <lyp256@qq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #325 (48a7a43) into master (5c65656) will increase coverage by 0.02%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   12.96%   12.98%   +0.02%     
==========================================
  Files          99      102       +3     
  Lines       15561    15601      +40     
==========================================
+ Hits         2017     2026       +9     
- Misses      13301    13332      +31     
  Partials      243      243              
Impacted Files Coverage Δ
pkg/scheme/core/v1/cri/containerd.go 12.74% <0.00%> (+1.85%) ⬆️
pkg/scheme/core/v1/cri/cri.go 52.94% <ø> (ø)
pkg/scheme/core/v1/cri/docker.go 0.00% <0.00%> (ø)
pkg/apis/core/v1/utils.go 54.27% <75.00%> (+0.15%) ⬆️
pkg/apis/core/v1/schema.go 69.72% <100.00%> (ø)
pkg/scheme/core/v1/k8s/kubeadm.go 1.57% <0.00%> (-1.11%) ⬇️
pkg/scheme/core/v1/k8s/node.go 0.35% <0.00%> (-0.02%) ⬇️
pkg/apis/core/v1/handler.go 0.31% <0.00%> (-0.01%) ⬇️
pkg/cli/registry/registry.go 0.00% <0.00%> (ø)
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)
... and 4 more

@lyp256
Copy link
Contributor Author

lyp256 commented Nov 2, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Nov 2, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 86c65036fa0fdb5b08d56fff91e77c234b97cea9

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyp256, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@kubeclipper-bot kubeclipper-bot merged commit 2cba2b3 into kubeclipper:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants