Skip to content

Conversation

lyp256
Copy link
Contributor

@lyp256 lyp256 commented Oct 26, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lyp256 <lyp256@qq.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2022
Signed-off-by: lyp256 <lyp256@qq.com>
@lyp256 lyp256 force-pushed the registry/controller branch from b1c91b5 to 9868321 Compare October 26, 2022 01:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #301 (4b3f9d4) into master (b5fb50a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   12.98%   12.97%   -0.01%     
==========================================
  Files          99       99              
  Lines       15539    15545       +6     
==========================================
  Hits         2017     2017              
- Misses      13279    13285       +6     
  Partials      243      243              
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.31% <0.00%> (-0.01%) ⬇️
pkg/scheme/core/v1/cri/containerd.go 11.34% <0.00%> (-0.04%) ⬇️
pkg/scheme/core/v1/cri/docker.go 0.00% <0.00%> (ø)

Signed-off-by: lyp256 <lyp256@qq.com>
@x893675
Copy link
Collaborator

x893675 commented Oct 26, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 08fec841f2987eff02c91f5cca3a434401da4251

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyp256, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2022
@kubeclipper-bot kubeclipper-bot merged commit a36b92c into kubeclipper:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants