Skip to content

add fuzzy search for node and event #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

add fuzzy search for node and event #299

merged 2 commits into from
Oct 25, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Oct 25, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

use `fuzzy~default-ip=xxx` to query node
use `fuzzy~ip=xxx` to query event
use `fuzzy~username=xxx` to query event

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@x893675
add fuzzy search for node and event
7e65780 
Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Oct 25, 2022

/milestone v1.3.1
/cc @lixd

@kubeclipper-bot kubeclipper-bot requested a review from lixd October 25, 2022 09:27
@kubeclipper-bot kubeclipper-bot added this to the v1.3.1 milestone Oct 25, 2022
@kubeclipper-bot kubeclipper-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Oct 25, 2022

@moweiwei frone-end need add this fuzzy query too

@x893675
fix test error
b69e317 
Signed-off-by: x893675 <x893675@icloud.com>
@codecov-commenter
Copy link

Codecov Report

Merging #299 (b69e317) into master (4c88fcd) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   12.98%   12.98%   -0.01%     
==========================================
  Files          99       99              
  Lines       15522    15539      +17     
==========================================
+ Hits         2015     2017       +2     
- Misses      13265    13279      +14     
- Partials      242      243       +1
Impacted Files Coverage Δ
pkg/models/platform/platformsetting.go 9.37% <25.00%> (+0.51%) ⬆️

lixd
lixd approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f709ec4ffabaf193793bbb7929c72d3f710500af

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit b5fb50a into kubeclipper:master Oct 25, 2022
@x893675 x893675 deleted the fuzzy-search branch November 3, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lixd lixd lixd approved these changes

Assignees

@lixd lixd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@x893675 @codecov-commenter @kubeclipper-bot @lixd