Skip to content

fix: provider update ignore status,rename terminating to removing #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix: provider update ignore status,rename terminating to removing #236

merged 1 commit into from
Sep 28, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Sep 28, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix some provider's bug

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

1.provider update ignore status field
2.rename terminating to removing
3.make nil map

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@lixd
fix: provider update ignore status,rename terminating to removing
732df27 
Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #236 (732df27) into master (0fee7ba) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   12.16%   12.16%   -0.01%     
==========================================
  Files         105      105              
  Lines       16589    16593       +4     
==========================================
  Hits         2018     2018              
- Misses      14333    14337       +4     
  Partials      238      238
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.33% <0.00%> (-0.01%) ⬇️

@lixd
Copy link
Contributor Author

lixd commented Sep 28, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Sep 28, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6e6de5b00804b81c3480dd6a0fb86900deba68f4

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@kubeclipper-bot kubeclipper-bot merged commit f9676af into kubeclipper:master Sep 28, 2022
@lixd lixd deleted the fix_provider branch October 25, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@x893675 x893675

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lixd @codecov-commenter @x893675 @kubeclipper-bot