fix: set resolver in jsonnet vm #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Pizarro Moreno <tpizarro@vmware.com>
jotadrilo
reviewed
Aug 20, 2024
Signed-off-by: Tomas Pizarro Moreno <tpizarro@vmware.com>
|
@mkmik in the name of Bitnami, would you be so kind to take a look at this? 😄 |
mkmik
approved these changes
Aug 26, 2024
|
@mkmik could you release a new version to include this fix? |
|
@tompizmor sure. here it is: https://github.com/kubecfg/kubecfg/releases/tag/v0.35.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since kubecfg version 0.29.1 (more precisely since this commit IIFNM) the resolve-images feature stopped working since the resolver was not set.
I noticed the
flagResolverandflagResolvFailflags were simply ignored and I also saw the existingWithResolverfunction was not used at all.I tested this MR in my environment and it works fine. Please let me know I case I have not considered something important.