Skip to content

fix: gate kustomize support behind alpha feature flag #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: gate kustomize support behind alpha feature flag #321

merged 2 commits into from
Aug 14, 2023

Conversation

jdockerty
Copy link
Member

@jdockerty jdockerty commented Aug 14, 2023 •
edited
Loading

Relates to the feature in #311

This was not previously behind the --alpha feature flag, when it should have been.

Now, we have an error when we do not use the --alpha feature flag with this, which is expected.

go run main.go show testdata/kustomize/test.jsonnet
ERROR error reading testdata/kustomize/test.jsonnet: RUNTIME ERROR: Get "kustomize+https://github.com/metacontroller/metacontroller/manifests/production": kustomize+https:// prefix is an alpha feature, please use the --alpha flag
        file:///home/influx/work/kubecfg/testdata/kustomize/test.jsonnet:2:27-115     object <anonymous>
        Field "metacontrollerUpstream"
        During manifestation
exit status 1

go run main.go show testdata/kustomize/test.jsonnet --alpha
---
apiVersion: v1
kind: Namespace
metadata:
  labels:
    app.kubernetes.io/name: metacontroller
  name: metacontroller
---
apiVersion: v1
SNIPPED FOR BREVITY

@jdockerty jdockerty self-assigned this Aug 14, 2023
@jdockerty jdockerty requested a review from mkmik August 14, 2023 11:04
@mkmik mkmik merged commit f8010ec into main Aug 14, 2023
@mkmik mkmik deleted the fix/alpha-gate-kustomize branch August 14, 2023 13:00
@mkmik
Copy link
Contributor

mkmik commented Aug 14, 2023

yeah, alternatively we could just not register the protocol handler if alpha features are not enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkmik mkmik mkmik approved these changes

Assignees

@jdockerty jdockerty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdockerty @mkmik