feat(parseHelmChart): support passing capabilities #310
Conversation
|
Hmmm, it looks like this can't be made an optional parameter (ref). It seems that native functions aren't able to set that (I may be wrong, so please correct me if my reading of the go-jsonnet source is incorrect. |
|
the jsonnet wrapper around the native calls can do default parameters |
Good call! I'll look into that soon! |
|
I'll fix the tests here soon! |
|
@mkmik I rebased to remove the extra commits (since it looks like y'all do merge commits). The tests should be passing now (they are locally!) Let me know if there's anything else I should do! Thanks!! |
|
sorry, feel free to ping me if I forget about things. |
Updates `parseHelmChart` to support passing `capabilities` to be passed as `chartutil.Capabilities` to the helm chart renderer. Right now, only `KubeVersion` is able to be passed. This is important for rendering helm charts that conditionally render `apiVersion`s, among other fields, based on the current Kubernetes Cluster. The [default is `1.20`](https://github.com/helm/helm/blob/f31d4fb3aacabf6102b3ec9214b3433a3dbf1812/pkg/chartutil/capabilities.go#L31) which doesn't work for all use cases.
|
@mkmik Rebased again to remove the merge commits (it seemed like that might've been the cause of the previous status failure) |
Updates
parseHelmChartto support passingcapabilitiesto be passed aschartutil.Capabilitiesto the helm chart renderer. Right now, onlyKubeVersionis able to be passed. This is important for rendering helm charts that conditionally renderapiVersions, among other fields, based on the current Kubernetes Cluster. The default is1.20which doesn't work for all use cases.I wasn't sure if this is the best approach, nor is this currently an
optionalfield (I will figure that out here soon). I wanted to send this out as proposal PR as well as to get feedback. We need this where I work currently, so I'm very motivated to get this working!Thank you ✨