cargo deny mutliple-fields ban #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
|
Test failed as it does locally: |
Signed-off-by: clux <sszynrae@gmail.com>
kazk
approved these changes
Nov 15, 2021
|
There's a warning Is this necessary for something? |
Technically no. i think Lars put it there as a convenience to allow things in a big org with private repos, but we don't have that stuff. I'll remove it. |
Signed-off-by: clux <sszynrae@gmail.com>
|
Warning gone. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html#the-multiple-versions-field-optional
to try to prevent issues like #709 in the future
i had issues originally, but deleted my local
Cargo.lockand on a rebuild all the duplicates had gone away.will add and remove a duplicate dependency here to ensure that this setup works.
(there are ways to temporarily whitelist from the duplicate ban list, so this shouldn't be a big inconvenience)