Install OpenSSL library in Windows CI workflow using Chocolatey #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b3bc6c to
b770bbc
Compare
|
Wow. This is great. It looks a lot more reasonable than the times I remember getting out of it. Don't have time to really dig into options right now, but initially this is a big 👍 from me. |
kazk
approved these changes
Dec 23, 2021
Signed-off-by: Chin-Ying Li <chinying.li@mail.utoronto.ca>
|
Going to merge this in. It will be good to see how it performs long term, and it's clearly a big improvement! Thanks again @ChinYing-Li |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Aims to solve #566.
Solution
Using Chocolatey to install the OpenSSL library; one big downside is that the installed version (OpenSSL 1.1.1 11 Sep 2018) is not the latest. Not sure if this is acceptable.
Have yet to figure out how to cache the files downloaded by OpenSSL, but the installation of OpenSSL only takes ~1 min.
As for the CI build time, linux and mac-os builds are not impacted (as expected).
The windows build takes ~11 min, which is ~3min more than the mac-os build: master CI vs. this branch.
Any suggestion is appreciated!