Add cargo-deny, clippy and rustfmt to CI - try #2 #611
Conversation
Signed-off-by: Lars Francke <lars.francke@gmail.com>
| @@ -1,4 +1,6 @@ | |||
| on: push | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
we can probably exclude master here if we are running the job on pr
There was a problem hiding this comment.
on:
push:
branches-ignore:
- 'master'
There was a problem hiding this comment.
While that's true we intentionally left it in for "our" own builds because if someone clicks on the green checkmark on the main repository he/she will see that clippy ran as well. More "marketing" than useful though.
Happy to remove it. I can push an update later.
There was a problem hiding this comment.
Oh, never considered that as a marketing point. I never click on that on master, I tend to look at the PR and look at required statuses there (because that list is generally bigger). I'm leaning more to limiting actions to points where it can give us actionable feedback, particularly since it's a finite free resource (2000min/mo)
There was a problem hiding this comment.
particularly since it's a finite free resource (2000min/mo)
I believe it's free for public projects.
GitHub Actions usage is free for both public repositories and self-hosted runners.
https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#about-billing-for-github-actions
Actions Usage is still 0 for this org.
There was a problem hiding this comment.
ohhh that's how it works. i thought that was a bug. 🥟
Signed-off-by: Lars Francke <lars.francke@gmail.com>
Signed-off-by: Lars Francke <lars.francke@gmail.com>
The previous PR #607 had issues (I couldn't get DCO right) so I created a new one.
This adds cargo-deny (for license checks and security advisories), rustfmt and clippy to the CI run for Pull Requests