Temporarily pin muslrust image for e2e tests due to unsupported openssl #1765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some very professional person has reasonably removed support for openssl due to it being EOL and without good replacements. I'll come up with a better e2e build for this later, but makig ci green for now by pinning to the last muslrust stable that had openssl. Signed-off-by: clux <sszynrae@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=====================================
Coverage 76.5% 76.5%
=====================================
Files 84 84
Lines 7893 7893
=====================================
Hits 6032 6032
Misses 1861 1861 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some very professional person has reasonably removed support for openssl in muslrust due to it being EOL and without good replacements.
I'll come up with a better e2e build for this later, but makig ci green for now by pinning to the last muslrust stable that had openssl.