Skip to content

Add missing derives on conversion types #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Add missing derives on conversion types #1759

merged 1 commit into from
May 14, 2025

Conversation

sbernauer
Copy link
Contributor

Motivation

We would like to use dbg! or assert_eq! on these types

Solution

Add the needed derives

@codecov Codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.5%. Comparing base (f0394e4) to head (d1ad7ce).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #1759   +/-   ##
=====================================
  Coverage   76.5%   76.5%           
=====================================
  Files         84      84           
  Lines       7888    7888           
=====================================
  Hits        6027    6027           
  Misses      1861    1861
Files with missing lines Coverage Δ
kube-core/src/conversion/types.rs 71.5% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

clux
clux reviewed May 13, 2025
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with this with one nit on Eq possibly being too strong

@clux clux added the changelog-add changelog added category for prs label May 13, 2025
@clux clux added this to the 1.1.0 milestone May 13, 2025
@sbernauer sbernauer force-pushed the fix/derive-conversion-types branch from f76f5d3 to 58ae3de Compare May 14, 2025 08:29
@sbernauer
Add missing derives on conversion types
d1ad7ce 
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech>
@sbernauer sbernauer force-pushed the fix/derive-conversion-types branch from 58ae3de to d1ad7ce Compare May 14, 2025 08:30
@sbernauer sbernauer requested a review from clux May 14, 2025 08:31
clux
clux approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@clux clux merged commit 83f5fe8 into kube-rs:main May 14, 2025
17 checks passed
@sbernauer
Copy link
Contributor Author

Thanks for the very quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-add changelog added category for prs
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @clux