Permit literal string validation for CEL expressions #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
=======================================
- Coverage 76.2% 76.2% -0.0%
=======================================
Files 84 84
Lines 7883 7889 +6
=======================================
+ Hits 6003 6006 +3
- Misses 1880 1883 +3
🚀 New features to boost your workflow:
|
clux
approved these changes
May 6, 2025
| use proc_macro2::TokenStream; | ||
| use syn::{parse_quote, Attribute, DeriveInput, Expr, Ident, Path}; | ||
|
|
||
| #[derive(FromField)] | ||
| #[darling(attributes(x_kube))] | ||
| struct XKube { | ||
| #[darling(multiple, rename = "validation")] | ||
| #[darling(multiple, rename = "validation", with = parse_expr::preserve_str_literal)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to simplify usage of CEL in schema generation with
x_kubemacro, users interested in simple validation should be able to specify simple&strdata without additional syntax, like mandatory.into()call for conversion intoRuletype required now.Solution
This change allows to write simple CEL expressions like so:
#[x_kube(validation = "self.nonNullable == oldSelf.nonNullable")]as opposed to previous:
#[x_kube(validation = "self.nonNullable == oldSelf.nonNullable".into())]or
#[x_kube(validation = Rule::new("self.metadata.name != 'forbidden'"))]and combine multiple more complex expressions with different input types, in case a
messageor areasoncontext needs to be specified: