Add suffix to generated struct by CELSchema
#1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
clux
approved these changes
Apr 20, 2025
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
=======================================
+ Coverage 76.2% 76.2% +0.1%
=======================================
Files 84 84
Lines 7852 7855 +3
=======================================
+ Hits 5977 5980 +3
Misses 1875 1875
🚀 New features to boost your workflow:
|
clux
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes issue with using associated methods for serde default in a
CELSchemamacro.Fixes #1746
Solution
Provide a suffix to the generated structure to avoid conflicts with outer block struct name, causing implementation overrides.