feat(runtime): Add series implementation for event recorder #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeabe4 to
e09e462
Compare
clux
reviewed
Dec 4, 2024
79074f2 to
e8e4b54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
+ Coverage 75.6% 75.8% +0.3%
=======================================
Files 82 82
Lines 7430 7513 +83
=======================================
+ Hits 5611 5693 +82
- Misses 1819 1820 +1
|
96240f4 to
dd650b2
Compare
|
Now all tests were passed but I forgot about DCO again... You can review it when you have time and if more improvements are needed I will work on them. If not I have to squash all those commits and we can merge. |
clux
added a commit
to kube-rs/controller-rs
that referenced
this pull request
Dec 9, 2024
for kube-rs/kube#1655 Signed-off-by: clux <sszynrae@gmail.com>
clux
reviewed
Dec 9, 2024
clux
reviewed
Dec 10, 2024
269eed5 to
12ab345
Compare
clux
reviewed
Dec 12, 2024
clux
reviewed
Dec 12, 2024
Signed-off-by: Alexander Gil <pando855@gmail.com>
12ab345 to
cb50617
Compare
|
I fixed the issues with the tests and squashed all commits. |
clux
approved these changes
Dec 12, 2024
Danil-Grigorev
pushed a commit
to Danil-Grigorev/kube
that referenced
this pull request
Dec 18, 2024
…1655) Signed-off-by: Alexander Gil <pando855@gmail.com>
clux
added a commit
to kube-rs/controller-rs
that referenced
this pull request
Dec 23, 2024
* test out new event recorder interface for kube-rs/kube#1655 Signed-off-by: clux <sszynrae@gmail.com> * cache recorder in Context to use the cache correctly Signed-off-by: clux <sszynrae@gmail.com> * event by ref Signed-off-by: clux <sszynrae@gmail.com> * use official now that it's released Signed-off-by: clux <sszynrae@gmail.com> * merge conflicts Signed-off-by: clux <sszynrae@gmail.com> * fix test compile Signed-off-by: clux <sszynrae@gmail.com> * gen Signed-off-by: clux <sszynrae@gmail.com> --------- Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of the event recorder just creates new events which is not enough for my event handling expectations.
Solution
I added a recorder implementation more similar to the one in client-go library. This implementation caches events in local and groups isomorphic events to increment series count on similar events.