add support for CRD annotations and labels in kube-derive #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
=======================================
+ Coverage 75.3% 75.3% +0.1%
=======================================
Files 82 82
Lines 7346 7371 +25
=======================================
+ Hits 5528 5550 +22
- Misses 1818 1821 +3
|
clux
reviewed
Nov 8, 2024
|
I rewrote the solution so the values are now passed as a two-string tuple. Also added the annotation support. |
clux
approved these changes
Nov 13, 2024
Signed-off-by: Andreas Metsälä <andreas.metsala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting annotations and labels on kube-derive generated CRDs.
Motivation
Writing Cluster API providers requires setting specific labels on the CRD: https://cluster-api.sigs.k8s.io/developer/providers/contracts#api-version-labels
Solution
New
annotationandlabelfields are added to kube-derive which can take a tuple of two strings as an argument.