Skip to content

allow null user in kubeconfig's context #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

allow null user in kubeconfig's context #1608

merged 1 commit into from
Oct 18, 2024

Conversation

aviramha
Copy link
Contributor

closes #1607

@aviramha
allow null user in kubeconfig's context
b3f4c9b 
Signed-off-by: Aviram Hassan <aviramyhassan@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (9dd62b9) to head (b3f4c9b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/config/file_loader.rs 87.5% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1608     +/-   ##
=======================================
+ Coverage   75.3%   75.3%   +0.1%     
=======================================
  Files         82      82             
  Lines       7342    7340      -2     
=======================================
+ Hits        5523    5524      +1     
+ Misses      1819    1816      -3
Files with missing lines Coverage Δ
kube-client/src/config/file_config.rs 74.2% <ø> (ø)
kube-client/src/config/file_loader.rs 84.0% <87.5%> (+5.2%) ⬆️

clux
clux approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@clux clux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are really running into all the degenerate cases 😬

thank you.

@clux clux added the changelog-fix changelog fix category for prs label Oct 18, 2024
@clux clux added this to the 0.97.0 milestone Oct 18, 2024
@clux clux merged commit 1addf43 into kube-rs:main Oct 18, 2024
17 checks passed
@aviramha
Copy link
Contributor Author

aviramha commented Oct 18, 2024 •
edited
Loading

It is a wild wild world out there..
Also, I blame that the upstream is Go so it's not strict thus translation is harder

@clux clux mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Milestone
0.97.0
Development

Successfully merging this pull request may close these issues.

empty user fails while kubectl doesn't
2 participants
@aviramha @clux