fix(kube-runtime): setup backoff with builder pattern #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filling the fields manually and leaving the current_interval out meant that the current_interval is set to its default rather than track the initial_interval The builder addresses this for us by setting it on the build method. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1603 +/- ##
=======================================
+ Coverage 75.2% 75.2% +0.1%
=======================================
Files 82 82
Lines 7336 7335 -1
=======================================
Hits 5514 5514
+ Misses 1822 1821 -1
|
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Thanks @clux, I've fixed the fmt and also added a test, so hopefully code cov is also ok now. |
clux
reviewed
Oct 14, 2024
This reverts commit fd3d1c2. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
95f519d to
a181dec
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filling the fields manually and leaving the current_interval out meant that the current_interval is set to its default rather than track the initial_interval
The builder addresses this for us by setting it on the build method.
Motivation
Noticed that the current_interval of the watcher backoff is left empty, which may lead to unintended behaviour.
Granted the difference is currently minimal (800ms to 500ms)
Solution
Using the builder pattern method from the backoff crate can be used to set the fields appropriately rather than simply the default value.